feat: adds /peers endpoint #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change a new API endpoint is added for accessing connected peers. The API is similar to the /api/v0/swarm/peers endpoint however it allows for multiple addresses and does not have to remain Kubo RPC compatible. The endpoint allows posting an address and therefore connecting to a new peer. Fixes: #608
dav1do
approved these changes
Dec 6, 2024
| .collect() | ||
| } | ||
| async fn peer_connect(&self, addrs: &[ceramic_api::Multiaddr]) -> Result<()> { | ||
| // Find peer id in one of the addresses |
There was a problem hiding this comment.
is it possible to make a weird request were you specify addresses with multiple peer IDs? it seems like we'd end up replacing the ID in following addresses or am I misunderstanding?
There was a problem hiding this comment.
hmm good point, we should check all peers ids are the same. As written it would likely just result in that address failing to connect but better to catch the error sooner.
|
Accidentally merged this into #618 I'll back it out. |
|
New PR here #628 |
nathanielc
had a problem deploying
to
dev-qa-2024
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change a new API endpoint is added for accessing connected peers. The API is similar to the /api/v0/swarm/peers endpoint however it allows for multiple addresses and does not have to remain Kubo RPC compatible.
The endpoint allows posting an address and therefore connecting to a new peer.
Fixes: #608