chore: add tests for eip55 cacaos #636
Open
+268
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure we're consistent with js-did and handle eip55
dav1do
commented
Dec 21, 2024
| "p": { | ||
| "aud": "did:key:zDnaeU3z6wJKYcxdeQdNB1b6bgnUZBtNy6u8W7AT3rVPdwj2f", | ||
| "domain": "app.passport.xyz", | ||
| "exp": "2024-12-24T20:27:13.330Z", |
There was a problem hiding this comment.
TODO: update these tests to use an explicit time check before the exp date so these don't start failing next week when now > 12/24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests using two events from the recent gitcoin signature failures. One is a full carfile parsed as an event, the second uses the envelope/cacao strings and parses them to demonstrate how one could swap in new envelope/cacao strings and make sure it passes (or fails).
Refactored a bit to make it easier to pass in data from a dag-json envelope downloaded from IPFS. I'd like to use the
Signaturetype instead of passing protected/signature bytes directly, but I didn't get the deserialization right while testing. There might be an easy way I'm just missing, but for now this is just an internal wrapper.