Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use explicit root user in release pr workflow #36

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

nathanielc
Copy link
Collaborator

No description provided.

@nathanielc nathanielc force-pushed the chore/release-pr-git branch from 93438f7 to 3cc8934 Compare April 29, 2024 21:12
@nathanielc nathanielc enabled auto-merge April 29, 2024 21:13
@christianlavoie
Copy link

Why release as root?

@nathanielc
Copy link
Collaborator Author

nathanielc commented Apr 29, 2024

Why release as root?

We are using our custom container, but custom containers are buggy with github actions as they do not properly chown all the needed directories to the right user. So using root is a simple fix. See https://stackoverflow.com/questions/68578638/how-to-checkout-repo-inside-the-docker-in-github-action

Also to be clear this is not a change to how we release (we always used root) but now we are being explicit about it.

Copy link

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nathanielc nathanielc added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 78b81c5 Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants