feat: ctrl+c/sigint handling and working directory override fix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop waiting for future and exit on ctrl+c. On a second ctrl+c, we give up on graceful shutdown and abort the task completely.
Make sure that the working directory is always an absolute path. When using the -d option, the ceramic daemon won't run due to path issues without this change.
dav1do
changed the title
dbcfd
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
ctrl+cexit handling and made some small adjustments to running in quiet mode. Fixes issue 9Now, we give up waiting for our futures and exit on
ctrl+c. On a secondctrl+c, we give up waiting for a graceful shutdown and abort the task completely. It's possible that something is still blocking and won't yield when we request cancellation, so we may need to listen to the channel at a lower level, but for now, the top level should be sufficient. All of our tasks should be repeatable, so if we abort and re-run wheel, it should succeed or it's a bug.Also, when a custom directory is specified, we make sure it is absolute. Before this, it was possible to fail to run the ceramic daemon as the start up script would reference a relative directory and fail to start.