Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint #110

Closed
wants to merge 6 commits into from
Closed

lint #110

wants to merge 6 commits into from

Conversation

telackey
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Merging #110 (5b2138d) into main (072b174) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files         148      148           
  Lines       16051    16051           
=======================================
  Hits        10657    10657           
  Misses       4918     4918           
  Partials      476      476           
Files Coverage Δ
x/registry/client/testutil/grpc.go 96.21% <100.00%> (ø)

@telackey telackey closed this Nov 21, 2023
@telackey telackey deleted the telackey/lint branch November 21, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants