Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ui: migrate to react-formule #2878

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

WIP ui: migrate to react-formule #2878

wants to merge 17 commits into from

Conversation

miguelgrc
Copy link
Contributor

@miguelgrc miguelgrc commented Feb 22, 2024

DO NOT MERGE YET (testing in cap-dev)

This PR supersedes #2859

Closes #2688, #2891

@miguelgrc miguelgrc changed the title ui: migrate to react-formule WIP ui: migrate to react-formule Feb 22, 2024
@miguelgrc miguelgrc force-pushed the with-formule branch 3 times, most recently from 294a4c8 to de99133 Compare February 23, 2024 13:40
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (5f2b9fd) to head (189f7e7).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2878      +/-   ##
==========================================
+ Coverage   75.05%   75.08%   +0.02%     
==========================================
  Files         194      194              
  Lines        7983     7983              
==========================================
+ Hits         5992     5994       +2     
+ Misses       1991     1989       -2     

see 1 file with indirect coverage changes

@miguelgrc miguelgrc force-pushed the with-formule branch 23 times, most recently from 7ced7a8 to 83c3340 Compare February 27, 2024 15:21
miguelgrc added 3 commits May 15, 2024 10:06
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
Signed-off-by: Miguel Garcia Garcia <[email protected]>
@pamfilos
Copy link
Collaborator

bump react-formule version

Signed-off-by: Miguel Garcia Garcia <[email protected]>
@miguelgrc miguelgrc force-pushed the with-formule branch 5 times, most recently from 4ec4401 to 0dc2d63 Compare November 8, 2024 14:03
* Split react-formule from bundle in order to have <20MB sourcemaps
* Avoid copying sourcemaps to final image to reduce size

Signed-off-by: Miguel Garcia Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: update Form component "transformError" component
3 participants