Upgrade focus trap to v8.0.0

[saket2403]

Summary

Upgrade focus trap to v8.0.0

Closes #3388

Deployment Link

https://terra-core-deployed-pr-#.herokuapp.com/

Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

[benbcai]

Do we know if bumping focus-trap-react from v6 to v8 on terra-dropdown-button and terra-overlay have any negative impact on consumers of these two components? In looking at the focus-trap-react v7 and v8 changelogs, it's hard to know what those breaking changes really impact.

[saket2403]

Do we know if bumping focus-trap-react from v6 to v8 on terra-dropdown-button and terra-overlay have any negative impact on consumers of these two components? In looking at the focus-trap-react v7 and v8 changelogs, it's hard to know what those breaking changes really impact.

There will be no impacts on consumers. The only impact it had has been handled in this PR which was caused by the PropTypes introduced in one of the Major versions. @benbcai

[jmsv6d]

It looks like the focus behavior has changed in the terra-dropdown-button from the screenshots. What is going on there. Is that desired?

[benbcai]

Consumers reported the following issue in terra-popup after bumping focus-trap-react from v6 to v8. Should we evaluate what impact terra-overlay and terra-dropdown-button may have before merging and releasing this change?

focus-trap.js?b846:291 Uncaught Error: Your focus-trap must have at least one container with at least one tabbable node in it at all times
    at updateTabbableNodes (focus-trap.js?b846:291)
    at Object.activate (focus-trap.js?b846:563)
    at FocusTrap.setupFocusTrap (focus-trap-react.js?fe41:190)
    at FocusTrap.componentDidMount (focus-trap-react.js?fe41:202)
    at commitLifeCycles (react-dom.development.js?61bb:19814)
    at commitLayoutEffects (react-dom.development.js?61bb:22803)
    at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:237)
    at invokeGuardedCallback (react-dom.development.js?61bb:292)
    at commitRootImpl (react-dom.development.js?61bb:22541)
react_devtools_backend.js:2526 The above error occurred in the <FocusTrap> component:
    in FocusTrap (created by PopupContent)
    in PopupContent (created by Popup)
    in Portal (created by Hookshot)
    in Hookshot (created by Popup)
    in Popup (created by Menu)
    in Menu (created by ConditionPopup)

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.