This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-alert] Update notification banner for screen reader experience #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eawww Test comment |
trandrew1023
force-pushed
the
alert-at-updates
branch
from
e3703d9
to
c066801
Compare
trandrew1023
changed the title
mjpalazzo
added
⭐ Accessibility Reviewed
eawww
approved these changes
Sep 21, 2023
trandrew1023
added
⭐ UX Reviewed
trandrew1023
force-pushed
the
alert-at-updates
branch
from
c066801
to
f8bd2a7
Compare
sycombs
approved these changes
Sep 21, 2023
sdadn
suggested changes
Sep 21, 2023
| let mockSpyUuid; | ||
| beforeAll(() => { | ||
| mockSpyUuid = jest.spyOn(uuidv4, 'v4').mockReturnValue('00000000-0000-0000-0000-000000000000'); | ||
| mockSpyUuid = jest.spyOn(uuidv4, 'v4').mockReturnValue(mockUuid); |
There was a problem hiding this comment.
We should hardcode this otherwise, it may show up as undefined when testing in other components.
There was a problem hiding this comment.
Will undo these!
There was a problem hiding this comment.
Updated here 4678cc7
artpark
approved these changes
Sep 22, 2023
sdadn
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Why it was changed:
Testing
This change was tested using:
To test, use Custom Prop Alert example under the Tests tab and add the title prop to the notification
Tested with Jaws and Edge/Chrome (also VO on Mac by Steven)
https://github.com/cerner/terra-core/assets/37750902/530dd406-a193-41d0-bdcb-4e1ddaf6535a
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9604
Thank you for contributing to Terra.
@cerner/terra