This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-dropdown]Added aria-haspoup and aria-controls attribute #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR ready for review? |
Yes. |
supreethmr
approved these changes
Oct 19, 2023
…down-aria-property
supreethmr
reviewed
Oct 26, 2023
Comment on lines
+220
to
+221
| aria-haspopup="true" | ||
| aria-controls={dropDownMenuListId} |
There was a problem hiding this comment.
we need to add aria-controls for split button as well :
There was a problem hiding this comment.
Implemented.
supreethmr
reviewed
Oct 26, 2023
Comment on lines
+13
to
+18
| beforeAll(() => { | ||
| mockSpyUuid = jest.spyOn(uuidv4, 'v4').mockReturnValue('00000000-0000-0000-0000-000000000000'); | ||
| }); | ||
|
|
||
| afterAll(() => { | ||
| mockSpyUuid.mockRestore(); |
There was a problem hiding this comment.
Need to add similar spy for splitbutton test as well
|
+1 |
sugan2416
approved these changes
Oct 30, 2023
added 2 commits
October 30, 2023 17:15
…down-aria-property
…rra-core into dropdown-aria-property
…down-aria-property
supreethmr
added
⭐ Accessibility Reviewed
…down-aria-property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixed- Screenreader not communicating menu
What was changed:
Added aria-haspoup and aria-controls attribute.
Why it was changed:
The screen reader is not announcing that it has a menu when the drop down button is navigation
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9694
Thank you for contributing to Terra.
@cerner/terra