This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-List] Added prop to Disable Tab Key Navigation for List Item #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
requested review from
sugan2416,
saket2403 and
MadanKumarGovindaswamy
saket2403
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
List items are considered as group of items and as per A11y standards group items should only be navigated with
arrowkeys and not with tab key. in order to achieve tab key navigation should be disabled for list-item.What was changed:
A prop has been introduced to disable the Tab Key Navigation by changing tabindex to
-1from0for selectable list item.To keep the change passive to existing terra-list consumer prop has been added to disable tab key navigation
Ensure Form Mode instructions as been removed from translations As per suggestion provided by UX A11y team
Why it was changed:
To Fix A11y failure found during fusion pass through.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9757
Thank you for contributing to Terra.
@cerner/terra