This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Arrange] Reflow issue when port is resized to 320x256 & Radio Button issue #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gt106551
force-pushed
the
Terra-Arrange-design-issue
branch
from
7b11add
to
c81c1ff
Compare
gt106551
force-pushed
the
Terra-Arrange-design-issue
branch
from
c81c1ff
to
fc6f448
Compare
supreethmr
reviewed
Oct 18, 2023
packages/terra-arrange/CHANGELOG.md
Outdated
Comment on lines
4
to
6
| *Fixed | ||
| * Fixed Terra Arrange Reflow issue `terra-arrange`. | ||
| * Fixed Terra Arrange Radio button issue `terra-arrange`. |
There was a problem hiding this comment.
@gt106551 Please maintain the existing format on change log for consistency
"Fixed Terra Arrange Reflow issue terra-arrange" This does not provide enough information about the fix made on this PR
Radio button issue is specific to the example hence not required this changelog should only have the changes made for component not for it's example
There was a problem hiding this comment.
Change log Updated
supreethmr
reviewed
Oct 18, 2023
| flex: 0 0; | ||
| } | ||
| } | ||
| } |
supreethmr
reviewed
Oct 18, 2023
Comment on lines
4
to
6
| *Fixed | ||
| * Fixed Terra Arrange Reflow issue `terra-arrange`. | ||
| * Fixed Terra Arrange Radio button issue `terra-arrange`. |
There was a problem hiding this comment.
change log are not clear and missing formatting
There was a problem hiding this comment.
Updated change log as per suggestion
supreethmr
reviewed
Oct 18, 2023
supreethmr
reviewed
Oct 18, 2023
Comment on lines
4
to
5
| *Fixed | ||
| * Fixed reflow issue when the viewport is resized to 320x256 px `terra-arrange`. |
There was a problem hiding this comment.
Suggested change
| *Fixed | |
| * Fixed reflow issue when the viewport is resized to 320x256 px `terra-arrange`. | |
| * Updated | |
| * Updated `terra-arrange` examples to use `terra-form-radio`. |
supreethmr
reviewed
Oct 18, 2023
packages/terra-arrange/CHANGELOG.md
Outdated
Comment on lines
4
to
5
| *Fixed | ||
| * Fixed reflow issue when the viewport is resized to 320x256 px `terra-arrange`. |
There was a problem hiding this comment.
Suggested change
| *Fixed | |
| * Fixed reflow issue when the viewport is resized to 320x256 px `terra-arrange`. | |
| * Fixed | |
| * Fixed reflow issue when the viewport is resized to 320x256 px. |
|
@gt106551 Can you add screenshot of the issue before and after code changes |
gt106551
force-pushed
the
Terra-Arrange-design-issue
branch
from
d59d4bd
to
0fd4c76
Compare
supreethmr
approved these changes
Oct 19, 2023
sdadn
approved these changes
Oct 19, 2023
|
+1 |
saket2403
added
⭐ UX Reviewed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before changes
After changes
Summary
1.Terra Arrange refow Issue- Previously, when port is resized to 320x256px buttons are moving out of example border. Now it has been resolved
2.Terra Arrange Radio button issue-Previously, the radio button options are only read individually as Yes and No and not in conjunction with their associated questions. Now it was announcing associated questions when we navigate to radio buttons
What was changed:
Added below media Query to fix reflow issue
@media (max-width: 320px) {
.fit {
align-self: flex-start;
flex: 0 0;
}
}
Why it was changed:
To fix reflow issue
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9728
Thank you for contributing to Terra.
@cerner/terra