This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-select] Combobox custom placeholder remove #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkumbhare116
changed the title
KV106606Viswanath
force-pushed
the
combobox_placeholder
branch
from
19409de
to
649218f
Compare
supreethmr
reviewed
Nov 2, 2023
Comment on lines
5
to
6
| *Fixed | ||
| *Fixed the `combobox` won't take custom placeholder text and only string `-Select- ` will be shown. |
There was a problem hiding this comment.
Suggested change
| *Fixed | |
| *Fixed the `combobox` won't take custom placeholder text and only string `-Select- ` will be shown. | |
| * Changed | |
| * Removed support for custom placeholder on the `combobox` |
There was a problem hiding this comment.
Updated with title "Breaking change" as per below comment,
supreethmr
reviewed
Nov 2, 2023
| /** | ||
| * Placeholder text. | ||
| */ | ||
| placeholder: PropTypes.string, |
There was a problem hiding this comment.
this is breaking change !! we need to update the upgrade guide and change log entry with title Breaking Change
KV106606Viswanath
force-pushed
the
combobox_placeholder
branch
from
87c9df1
to
14f0569
Compare
|
This pull request is closed for the reasons stated in Jira:UXPLATFORM-9731 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To ensure the Form - Select Combobox meets accessibility standards for 2.4.6 Heading and Labels we need to ensure the place holder text does not have the ability to have custom text. String for what should display as placeholder text in the Acceptance Criteria
What was changed:
Why it was changed:
Combobox shouldn't have the option for custom placeholder according to design doc
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9731
Thank you for contributing to Terra.
@cerner/terra