This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-select-combobox] Added no results found text in combobox #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KV106606Viswanath
force-pushed
the
KV106606-Form-Select-Combobox-No-results-found
branch
from
ca7d766
to
edebf5e
Compare
KV106606Viswanath
force-pushed
the
KV106606-Form-Select-Combobox-No-results-found
branch
from
edebf5e
to
9d27b65
Compare
|
@KV106606Viswanath can we add WDIO test to validate no results scenario added for combobox |
Updated |
supreethmr
approved these changes
Nov 3, 2023
saket2403
approved these changes
Nov 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when we enter some list item which is not there in the combobox list, there is no message to convey that there are no results found with search text. Now it has been added and we can see the text as "No results found" along with with the search text.
What was changed:
No results found text has been added when we find some text which is not there in the list.
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9732
Thank you for contributing to Terra.
@cerner/terra