This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-arrange] Revert change for small viewport flex css properties #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Apr 23, 2024
| @@ -42,12 +38,4 @@ | |||
| .default { | |||
| align-self: flex-start; | |||
| } | |||
|
|
|||
| @media (max-width: 320px), (max-height: 256px) { | |||
There was a problem hiding this comment.
Is Mpage Fusion components that consumes terra-arrange are tested with these changes ? Can add the screenshots on Jira as well before merging this pr
There was a problem hiding this comment.
@supreethmr Yup, the MPages Fusion component, ContentDecorator, has been tested with these changes. Here is the before and after when the window is resized to 320 x 256px.
Before:
After:
Interestingly, the flex property doesn't do anything in the example. The parent div has a style of display: block. So flex has no effect on it.
If the before change's styling of flex: 0 0 were actually to be applied, it would look like this:
JessieRandle
approved these changes
Apr 23, 2024
adoroshk
approved these changes
Apr 23, 2024
sycombs
approved these changes
Apr 23, 2024
supreethmr
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Removed the flex property that was only available during a viewport smaller than 320px x 256px. After testing more thoroughly, I found that these did not have the intended behavior and was causing issues in IE.
Why it was changed:
To fix the IE overlapping elements bug.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10305
Thank you for contributing to Terra.
@cerner/terra