feat: Add envvar for retrying git operations #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
inteon
reviewed
Feb 7, 2025
Behind the CyberArk corporate proxy, we often see git failures if many clone / pull operations are performed in rapid succession. This commit adds a simple retry mechanism, aiming to do the simplest possible thing to reduce flakes in our environments. Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
retry_and_delay
branch
from
544e63d to
7990c94
Compare
inteon
reviewed
Feb 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based loosely on similar code we recently added to cmrel.
Context: Behind the CyberArk corporate proxy, we often see git failures if many clone / pull operations are performed in rapid succession, which with klone is a common pattern.
This PR adds a simple retry mechanism, aiming to do the simplest possible thing to reduce flakes in our environments. This also uses a static delay between retries rather than any fancier solution.
The variable is called
KLONE_GIT_RETRY_ATTEMPTS