-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional support for subject annotations #29
Additional support for subject annotations #29
Conversation
69a3613
to
7420e75
Compare
Hey! Thank you for the great work. I will take a look at the PR on Monday. Thanks! Note: I'll be on PTO from Tue 27 June to Sun 23 July. Please ping another maintainer (such as |
Hey, I just realized that the project doesn't have unit tests for |
7420e75
to
f7289ab
Compare
@maelvls no rush, but have rebased and fixed merge conflicts. 🙏 Edit: Sorry looks like I missed your reply above! I've joined the cert-manager-dev slack channel |
@maelvls have updated PR with some tests, no rush but have a look when you get a chance! :) |
Hi! Let me know if I can be of any help 👍 |
Sorry I haven't had much time to look at this recently, I've addressed pretty much all points except the reconcile test. Since the reconcile logic lives in the controller.go were you wanting to see a new test suite specifically there (ie. controller_test.go) or just include it in the sync test suite? Or if you have time and want to add the test feel free! Thanks |
Hey. As suggested, I added a test in 6f0eddb. Do you want to rebase or would you like me to rebase? Update: I'll rebase if that's OK for you. |
6f0eddb
to
a02b621
Compare
/approve I should ask for another pair of eyes to look at the new test I have added, but I decided to go ahead an LGTM anyways because why not! |
I'll release your changes in the next release (v0.5.0). Since I already release v0.4.0 yesterday, I am unsure whether I should be releasing v0.5.0 right now or not... For later: here is the release notes I'll use when releasing v0.5.0: You can now use more annotations! Thanks to @ctrought's work, you can now use the annotations To help migrating the annotations from Ingresses to Routes, the annotation |
That's great, thank you for finishing the PR up @maelvls !! |
Signed-off-by: Craig Trought <[email protected]>
Signed-off-by: Craig Trought <[email protected]>
Signed-off-by: Craig Trought <[email protected]>
Signed-off-by: Craig Trought <[email protected]>
Signed-off-by: Craig Trought <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
a02b621
to
e1cc7e6
Compare
@maelvls anything else required before this gets merged? Just rebased after a different PR was merged. 🙏 Ty! |
It seems like everything is good to go! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey, I'll cut v0.5.0 with your changes today. Update: done! |
@maelvls , amazing & thank you!! |
Mainly adds support for additional subject annotations now supported in v1.12 of cert-manager, also upgrades cert-manager to v1.12.1 (though I see another PR for that already).
Allow use of the
cert-manager.io/issuer
annotation, in addition to the existingcert-manager.io/issuer-name
. This ingress annotation is more familiar for people using cert-manager on ingress already and makes switching over a bit simpler.https://cert-manager.io/docs/usage/ingress/#supported-annotations
Ignore routes that are owned by ingress objects as cert-manager may already be providing certificates via ingresses that openshift-controller-manager then creates and route for. This helps users like myself already using cert-manager on OpenShift via OCM ingress -> route method to slowly migrate to using
openshift-routes
on routes without the two potentially conflicting.