Additional support for subject annotations

[ctrought]

Mainly adds support for additional subject annotations now supported in v1.12 of cert-manager, also upgrades cert-manager to v1.12.1 (though I see another PR for that already).

Allow use of the cert-manager.io/issuer annotation, in addition to the existing cert-manager.io/issuer-name. This ingress annotation is more familiar for people using cert-manager on ingress already and makes switching over a bit simpler.
https://cert-manager.io/docs/usage/ingress/#supported-annotations

Ignore routes that are owned by ingress objects as cert-manager may already be providing certificates via ingresses that openshift-controller-manager then creates and route for. This helps users like myself already using cert-manager on OpenShift via OCM ingress -> route method to slowly migrate to using openshift-routes on routes without the two potentially conflicting.

• feat: support subject annotations on route
• fix: ignore routes owned by ingress
• fix: support ingress issuer name annotation
• chore: upgrade cert-manager to v1.12.1

[maelvls]

Hey! Thank you for the great work. I will take a look at the PR on Monday. Thanks!

Note: I'll be on PTO from Tue 27 June to Sun 23 July. Please ping another maintainer (such as @inteon) if you need a quicker review.

[maelvls]

Hey, I just realized that the project doesn't have unit tests for createNextCR, which makes me a bit nervous given how much additional logic is added in this PR. I shared the same worry in #28 (comment). I'll try to email you and @vinny-sabatini so that we can coordinate (I couldn't find you on the Kubernetes Slack).

[ctrought]

@maelvls no rush, but have rebased and fixed merge conflicts. 🙏

Edit: Sorry looks like I missed your reply above! I've joined the cert-manager-dev slack channel

[ctrought]

@maelvls have updated PR with some tests, no rush but have a look when you get a chance! :)

[maelvls]

Hi! Let me know if I can be of any help 👍

[ctrought]

Hi! Let me know if I can be of any help 👍

Sorry I haven't had much time to look at this recently, I've addressed pretty much all points except the reconcile test. Since the reconcile logic lives in the controller.go were you wanting to see a new test suite specifically there (ie. controller_test.go) or just include it in the sync test suite? Or if you have time and want to add the test feel free! Thanks

[maelvls]

Hey. As suggested, I added a test in 6f0eddb. Do you want to rebase or would you like me to rebase?

Update: I'll rebase if that's OK for you.

[maelvls]

/approve
/lgtm

I should ask for another pair of eyes to look at the new test I have added, but I decided to go ahead an LGTM anyways because why not!

[maelvls]

I'll release your changes in the next release (v0.5.0). Since I already release v0.4.0 yesterday, I am unsure whether I should be releasing v0.5.0 right now or not...

For later: here is the release notes I'll use when releasing v0.5.0:

---

You can now use more annotations! Thanks to @ctrought's work, you can now use the annotations cert-manager.io/email-sans, cert-manager.io/subject-organizations, cert-manager.io/subject-organizationalunits, cert-manager.io/subject-countries, cert-manager.io/subject-provinces, cert-manager.io/subject-localities, cert-manager.io/subject-postalcodes, cert-manager.io/subject-streetaddresses, and cert-manager.io/subject-serialnumber. The documentation for the annotations is identical to the Ingress annotations and can be read in the Ingress Usage page.

To help migrating the annotations from Ingresses to Routes, the annotation cert-manager.io/issuer can now be used as an alternative to cert-manager.io/issuer-name. Both annotations offer the same functionality. Note that the annotation cert-manager.io/cluster-issuer has not been brought to openshift-routes.

[ctrought]

That's great, thank you for finishing the PR up @maelvls !!

[ctrought]

@maelvls anything else required before this gets merged? Just rebased after a different PR was merged. 🙏 Ty!

[maelvls]

It seems like everything is good to go!

/lgtm
/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maelvls]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maelvls]

Hey, I'll cut v0.5.0 with your changes today.

Update: done!

[ctrought]

@maelvls , amazing & thank you!!