-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement private key size annotation #48
Conversation
Signed-off-by: Norwin Schnyder <[email protected]>
6762f17
to
7d16bd2
Compare
@jacksgt would be really appreciated if you could quickly have a look at this PR. |
@maelvls if there are no further changes required, would you be able to merge the PR and consider releasing it? |
/approve Yes, let's have it released! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! Very much appreciated 😄 |
This PR introduces a new feature that allows users to specify the private key size in the
Route
resource, similar to the functionality currently available for theIngress
resource. With the increasing shift away from the default RSA key size of2048
, which is often no longer supported or used, this addition provides users with the flexibility to define a key size that aligns with their security requirements and best practices.