Document CRD considerations when using helm #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
do-not-merge/work-in-progress
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jetstack-bot
added
dco-signoff: no
jetstack-bot
added
dco-signoff: yes
hawksight
changed the title
jetstack-bot
added
dco-signoff: no
jetstack-bot
added
dco-signoff: yes
Signed-off-by: Peter Fiddes <[email protected]>
jetstack-bot
removed
the
do-not-merge/work-in-progress
|
/assign @maelvls |
|
/cc @maelvls |
maelvls
approved these changes
Jun 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawksight, maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to clarify the available options for managing cert-manager CRDs and how they differ to standard helm method. I did add a recommendation for the user which I am unsure if that is the "right" thing to do here. My default is to be secure and managing CRDs outside of helm gives the most safety in that you shouldn't ever have a scenario where helm removes those CRDs causing issues.
All that said, the
--set installCRDs=trueoption is very convenient and I use it daily. It seems most of the users I asked use this option and don't have concerns. So the intent here is just to highlight the considerations and give users an idea about which method they should choose. Ultimately this is down to each user of course and people can do what they like.