Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiVersion in zeroSSL ClusterIssuer example #1267

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Update apiVersion in zeroSSL ClusterIssuer example #1267

merged 1 commit into from
Sep 5, 2023

Conversation

cloudoutloud
Copy link
Contributor

@cloudoutloud cloudoutloud commented Aug 6, 2023

  • Update apiVersion in zeroSSL ClusterIssuer example
  • cert-manager.io/v1alpha2 has been deprecated for some time, remove from example to avoid errors when copying and pasting config.

Signed-off-by: cloudoutloud <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2023
@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 979c7c0
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64cf6187559ebb000870674c
😎 Deploy Preview https://deploy-preview-1267--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting this mistake!
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@jetstack-bot jetstack-bot merged commit 17aaa01 into cert-manager:master Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants