Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the "Configuration" and "Usage" top-level menu items #1282

Merged

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 5, 2023

Based on what was proposed in #1260

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@inteon
Copy link
Member Author

inteon commented Sep 5, 2023

/approve

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 10c7a76
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64f88eaaaf45b700080dfa3f
😎 Deploy Preview https://deploy-preview-1282--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon inteon requested a review from wallrj September 6, 2023 09:57
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally still prefer "Issuing Certificates",
but if you're going to use "Requesting Certificates", then that should also be the title of the Overview / Introduction page for that section:

And ideally, the URL path segment should also change.

@inteon inteon requested a review from wallrj September 6, 2023 14:37
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2023
@inteon
Copy link
Member Author

inteon commented Sep 6, 2023

I personally still prefer "Issuing Certificates", but if you're going to use "Requesting Certificates", then that should also be the title of the Overview / Introduction page for that section:

And ideally, the URL path segment should also change.

I did not change the URL, because I think it this is the easiest way to not break any links.

@inteon
Copy link
Member Author

inteon commented Sep 6, 2023

@wallrj I updated the content of those pages (see https://deploy-preview-1282--cert-manager-website.netlify.app/docs/usage/)

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. As we discussed this morning, merging this will leave the website in an inconsistent state where the section called "Requesting Certificates" contains documents about prometheus metrics.
How about we merge this and the followup PR into a feature branch.
Then the feature branch preview can be presented in #cert-manager-dev for feedback before we make it live.

/lgtm
/hold in case you want to merge this into a feature branch

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 6, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon
Copy link
Member Author

inteon commented Sep 6, 2023

I think it's not too disruptive, I fear that having a feature branch will just complicate things a lot (given that we might want to make more additional changes on master too).
/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@jetstack-bot jetstack-bot merged commit 20899b2 into cert-manager:master Sep 6, 2023
1 check passed
@inteon inteon deleted the rename_top_level_menu_items branch September 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants