-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the "Configuration" and "Usage" top-level menu items #1282
Rename the "Configuration" and "Usage" top-level menu items #1282
Conversation
Signed-off-by: Tim Ramlot <[email protected]>
/approve |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally still prefer "Issuing Certificates",
but if you're going to use "Requesting Certificates", then that should also be the title of the Overview / Introduction page for that section:
And ideally, the URL path segment should also change.
Signed-off-by: Tim Ramlot <[email protected]>
I did not change the URL, because I think it this is the easiest way to not break any links. |
@wallrj I updated the content of those pages (see https://deploy-preview-1282--cert-manager-website.netlify.app/docs/usage/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. As we discussed this morning, merging this will leave the website in an inconsistent state where the section called "Requesting Certificates" contains documents about prometheus metrics.
How about we merge this and the followup PR into a feature branch.
Then the feature branch preview can be presented in #cert-manager-dev for feedback before we make it live.
/lgtm
/hold in case you want to merge this into a feature branch
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it's not too disruptive, I fear that having a feature branch will just complicate things a lot (given that we might want to make more additional changes on master too). |
Based on what was proposed in #1260