Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same method for creating on-page references links across all pages #1287

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 6, 2023

We often want to add a linkable on-page reference (eg. https://cert-manager.io/docs/installation/supported-releases/#bug-fixes-support). We are not consistent in the methods we use to create such links.

I think we can agree that creating an empty tag before your title works best. This PR replaces all other methods with this method.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@inteon inteon requested a review from wallrj September 6, 2023 14:25
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 881c6ec
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64f88b3838ad6a000899f920
😎 Deploy Preview https://deploy-preview-1287--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon inteon changed the title Use same method for creating on-page references across all pages Use same method for creating on-page references links across all pages Sep 6, 2023
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@jetstack-bot jetstack-bot merged commit 465e0c7 into master Sep 7, 2023
5 checks passed
@inteon inteon deleted the standardise_page_references branch October 2, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants