Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for v1.15.3 and update latest cert-manager version #1537

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add release notes for v1.15.3 and update latest cert-manager version #1537

merged 2 commits into from
Aug 16, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Aug 16, 2024 •
edited
Loading

  • adds release notes for cert-manager v1.15.3
  • updates the latest cert-manager version to v1.15.3

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a63889b
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66bf2e35a8159600085a4585
😎 Deploy Preview https://deploy-preview-1537--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wallrj
wallrj requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small typo.

/approve

content/docs/releases/release-notes/release-notes-1.15.md Outdated Show resolved Hide resolved
@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@inteon @wallrj
Fix typo
a63889b 
Co-authored-by: Richard Wall <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
wallrj
wallrj approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth noting that this bug does not affect the webhook of the cert-manager community operator,
because it uses an OLM mechanism for managing webhook certs:

https://github.com/cert-manager/cert-manager-olm/blob/b4fb78dcb7d29f38601667c73525aa9d52f1669a/hack/fixup-csv#L120-L126

/lgtm
/hold until released

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 16, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wallrj
wallrj reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also be worth mentioning that this bug would also affect people using the dynamic TLS certificate for metrics:

@inteon
Copy link
Member Author

inteon commented Aug 16, 2024

This has been released here: https://github.com/cert-manager/cert-manager/releases/tag/v1.15.3

/unhold

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@inteon inteon merged commit 6337486 into cert-manager:master Aug 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inteon @wallrj