Cview-issuer for cert-manager #1541
Conversation
cview-issuser-1 Signed-off-by: Krzysztof Pudłowski <[email protected]>
cert-manager-prow
bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Krzysztof Pudłowski <[email protected]>
Signed-off-by: Krzysztof Pudłowski <[email protected]>
|
Hi, Can you prioritize this issue? |
Signed-off-by: Krzysztof Pudłowski <[email protected]>
|
@jakexks Please help me with this npm check. I do not understand why it is failed. |
Signed-off-by: Krzysztof Pudłowski <[email protected]>
Signed-off-by: Krzysztof Pudłowski <[email protected]>
Signed-off-by: Krzysztof Pudłowski <[email protected]>
|
The spelling has been corrected. |
This comment was marked as spam.
This comment was marked as spam.
cert-manager-prow
bot
added
the
do-not-merge/work-in-progress
This comment was marked as spam.
This comment was marked as spam.
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
|
@djkormo: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
@djkormo: GitHub didn't allow me to assign the following users: sorah. Note that only cert-manager members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Hey, thanks for contributing!
It looks like the deploy preview is showing a broken link for this. Looks like the ca:cview-issuer link hasn't been added.
Could you fix that? I'd be happy to merge then!
| @@ -15,6 +15,7 @@ The following list contains all known cert-manager issuer integrations. | |||
| | 🥈 | aws-privateca-issuer | [📄][config:aws-privateca-issuer] | [AWS Private Certificate Authority][ca:aws-privateca-issuer] | - | [✔️][release:aws-privateca-issuer] | ✔️ | | |||
| | 🥈 | ca-issuer (in-tree) | [📄][config:ca-issuer] | CA issuer | - | [✔️][release:cert-manager] | ✔️ | | |||
| | 🥈 | command-issuer | [📄][config:command-issuer] | [Keyfactor Command][ca:command-issuer] | - | [✔️][release:command-issuer] | ✔️ | | |||
| | 🥈 | cview-issuer | [📄][config:cview-issuer] | [cview-issuer][ca:cview-issuer] | - | [✔️][release:cview-issuer] | ❌ | | |||
There was a problem hiding this comment.
Do you have a releases page? We have to make sure the issuer has had a release in the last 12 months.
Also, can you confirm the following (does not require a proof):
- These issuers are known to support and honor approval.
There was a problem hiding this comment.
There is a release page for helm chart. But the release of issuer image is in a private repo.
Images for issuer are visible on docker hub . https://hub.docker.com/r/devsecurely/cview-issuer/tags
Signed-off-by: Krzysztof Pudłowski <[email protected]>
cert-manager-prow
bot
added
size/S
Signed-off-by: Krzysztof Pudłowski <[email protected]>
There was a problem hiding this comment.
Thanks for updating the link, it looks correct now!
There's one last thing based on inteon's comment - can you confirm that your issuer honors approval?
That is, it will not issue for a cert request which is not marked "Approved"?
If your issuer is based on issuer-lib then it should handle approval. If it's more custom it might not, so we need to check!
cert-manager-prow
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djkormo, inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
|
Code was written on the base from this repo It does handle approval. |
|
/unhold |
cert-manager-prow
bot
removed
the
do-not-merge/hold
New issuer has been created for cert-manager. It uses cview as dedicated CA. The website of this produkt product https://www.secure-ly.com/c-view-professional-certificates-lifecycle-management/ . Issuer is not open-sourced.