-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Merge self-upgrade-master into master #1545
Conversation
Signed-off-by: cert-manager-bot <[email protected]>
✅ Deploy Preview for cert-manager ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-cert-manager-website-verify |
@SgtCoDFish: No presubmit jobs available for cert-manager/website@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In cert-manager#789 we removed the presubmit for the website repo, but the test is still marked as required for the website repo. I saw this test being waited for in cert-manager/website#1545 which alerted me to something being wrong. Signed-off-by: Ashley Davis <[email protected]>
I was told that closing and re-opening the PR would trigger the job which wasn't running. That seems to have worked. |
This PR is auto-generated to bump the Makefile modules.