Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Merge self-upgrade-master into master #1545

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 5, 2024

This PR is auto-generated to bump the Makefile modules.

@github-actions github-actions bot added the skip-review Indicates a PR is trusted, used by tide for auto-merging PRs. label Sep 5, 2024
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for cert-manager ready!

Name Link
🔨 Latest commit 1f3c1ed
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66d902cf49c50900084cad33
😎 Deploy Preview https://deploy-preview-1545--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@SgtCoDFish
Copy link
Member

/retest

@SgtCoDFish
Copy link
Member

/test pull-cert-manager-website-verify

@cert-manager-prow
Copy link
Contributor

@SgtCoDFish: No presubmit jobs available for cert-manager/website@master

In response to this:

/test pull-cert-manager-website-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

SgtCoDFish added a commit to SgtCoDFish/cert-manager-testing that referenced this pull request Sep 5, 2024
In cert-manager#789 we removed the presubmit for the website repo, but the test is
still marked as required for the website repo. I saw this test being
waited for in cert-manager/website#1545 which
alerted me to something being wrong.

Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish SgtCoDFish closed this Sep 5, 2024
@SgtCoDFish SgtCoDFish reopened this Sep 5, 2024
@SgtCoDFish
Copy link
Member

I was told that closing and re-opening the PR would trigger the job which wasn't running. That seems to have worked.

@cert-manager-prow cert-manager-prow bot merged commit 6ec7f87 into master Sep 5, 2024
7 checks passed
@SgtCoDFish SgtCoDFish deleted the self-upgrade-master branch September 5, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review Indicates a PR is trusted, used by tide for auto-merging PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants