Skip to content

Commit

Permalink
TST: TestAmqp.test_acknowledge: skip also on 3.11
Browse files Browse the repository at this point in the history
this specific tests consistently fails when running on GitHub on Python
3.11 but not everywhere else, so ignore it
  • Loading branch information
sebix committed Dec 1, 2024
1 parent b7f9cf3 commit 5690817
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
- Install build dependencies for `pymssql` on Python 3.8 as there are no wheels available for this Python version (PR#2542 by Sebastian Wagner).
- Install `psql` explicitly for workflow support on other plattforms such as act (PR#2542 by Sebastian Wagner).
- Create intelmq user & group if running privileged to allow dropping privileges (PR#2542 by Sebastian Wagner).
- `intelmq.tests.lib.test_pipeline.TestAmqp.test_acknowledge`: Also skip on Python 3.11 besides on 3.8 when running on CI (PR#2542 by Sebastian Wagner).

### Tools

Expand Down
4 changes: 2 additions & 2 deletions intelmq/tests/lib/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ def test_reject(self):
self.pipe.reject_message()
self.assertEqual(SAMPLES['normal'][1], self.pipe.receive())

@unittest.skipIf(os.getenv('CI') == 'true' and sys.version_info[:2] == (3, 8),
'Fails on CI with Python 3.8')
@unittest.skipIf(os.getenv('CI') == 'true' and sys.version_info[:2] in ((3, 8), (3, 11)),
'Fails on CI with Python 3.8 and 3.11')
def test_acknowledge(self):
self.pipe.send(SAMPLES['normal'][0])
self.pipe.receive()
Expand Down

0 comments on commit 5690817

Please sign in to comment.