Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team page #27

Merged
merged 22 commits into from
Jan 1, 2025
Merged

feat: add team page #27

merged 22 commits into from
Jan 1, 2025

Conversation

nunom27
Copy link
Contributor

@nunom27 nunom27 commented Sep 30, 2024

No description provided.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit 003b0bb
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/6775933e01658c0008e91f62
😎 Deploy Preview https://deploy-preview-27--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos
Copy link
Member

@nunom27 time to make this not a draft anymore! 👀

@diogogmatos diogogmatos linked an issue Oct 15, 2024 that may be closed by this pull request
@diogogmatos diogogmatos marked this pull request as ready for review November 2, 2024 15:39
@diogogmatos
Copy link
Member

Maybe we can add a transition to the ListBox component using this: https://tailwindcss.com/blog/utility-friendly-transitions-with-tailwindui-react 👀

@nunom27
Copy link
Contributor Author

nunom27 commented Nov 2, 2024

@diogogmatos I was thinking about doing something neater, leveraging the capabilities of the framer motion library.

@diogogmatos
Copy link
Member

On mobile the the team name is getting centered when the texts wraps around.

image

@nunom27 nunom27 marked this pull request as draft November 2, 2024 15:57
@joaodiaslobo
Copy link
Member

Missing 1995-1996

@diogogmatos diogogmatos linked an issue Nov 6, 2024 that may be closed by this pull request
@diogogmatos
Copy link
Member

Heyy, just a note: don't forget to place this page in /[lang]/about/team instead of /about/team because of the internationalization feature :)

@nunom27 nunom27 marked this pull request as ready for review November 20, 2024 23:37
@nunom27 nunom27 requested a review from diogogmatos November 20, 2024 23:38
@nunom27 nunom27 requested a review from joaodiaslobo November 28, 2024 19:58
@diogogmatos
Copy link
Member

diogogmatos commented Dec 3, 2024

Feature:

We should add a query parameter to the URL that changes in accordance to what year is selected (ex: ?year=2024-2025). This way, when we refresh the page on a certain year it will stay on that year instead of resetting to the last year again.

Issue:

Also, an issue that @JoaoCoelho2003 noticed is that, on low connectivity, when changing between teams of different years some pictures take longer to update and others are giving a 500 error code, this results in the image of the previously selected year being shown in the place of the current year, so some people will have a name that does not correspond to the picture (at least until the correct image loads, but sometimes it doesn't load at all):

image image

image

Maybe it's some problem with the Cloudflare buckets?

diogogmatos
diogogmatos previously approved these changes Jan 1, 2025
Copy link
Member

@diogogmatos diogogmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! First complete page of the project 🙌

@nunom27 nunom27 merged commit f31806f into main Jan 1, 2025
4 checks passed
@nunom27 nunom27 deleted the nm/team-page branch January 1, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: /about/team page feat: select component
3 participants