Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of component for project card #67

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

RicoPleasure
Copy link
Contributor

This is how it looks on mobile:
image
And desktop:
image

It seems to look good on these sizes but I need help to decide how it should look like on intermediate sizes, please. Take a look:
image

  • Should each box grow up with the screen or what?

Also, in larger screens it looks like that:
image

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit 52b4502
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/67b35d643281590008066a9a
😎 Deploy Preview https://deploy-preview-67--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RicoPleasure RicoPleasure linked an issue Jan 15, 2025 that may be closed by this pull request
…not be done on this PR
Copy link
Contributor

@AfonsoMartins26 AfonsoMartins26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but let's wait for another review. 🚀 👍

@RicoPleasure
Copy link
Contributor Author

Fixed as suggested. It should be good now.

diogogmatos
diogogmatos previously approved these changes Feb 17, 2025
Copy link
Member

@diogogmatos diogogmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remember to delete the preview of the component in the about page before merging 🙌🏼

@RicoPleasure RicoPleasure merged commit 482c054 into main Feb 17, 2025
4 checks passed
@RicoPleasure RicoPleasure deleted the ep/project-card branch February 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: project card
3 participants