rework TXT record handling and tokenization #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Niehage <[email protected]>
Signed-off-by: Kenny Niehage <[email protected]>
fix handling of TXT records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the crawler does not handle TXT records properly, breaking SPF record entries in cases where the TXT record is split in several parts (e.g.
0.spf0.hubspotemail.net). The crawler currently also handles other TXT records even if they don't start withv=spf1which is against the specification.This PR superseeds #19 as we currently use the modified version in production. This modified version also introduces some code cleanups suggested by @tresni in his fork. Our modified version might introduce additional improvements in the future.