Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain calculation where domain isn't set #73

Closed

Conversation

jamesrswift
Copy link
Collaborator

Fixes #72

Changes the default domain from (0, 0) to (none, none). It appears just to have been a typo that none of the tests picked up because they all included the origin.

Adjusted MRE (adjusted ticks)

#test-case({
  import draw: *
  set-style(rect: (stroke: none))

  plot.plot(size: (6, 4), x-tick-step: 0.5, {
    plot.add(domain: (100, 101), calc.sin)
    plot.annotate(padding: .1, {
      content( (101.5, 0), [A])
    })
  })
})

image

@johannes-wolf johannes-wolf self-requested a review October 28, 2024 20:48
@johannes-wolf johannes-wolf added the 👿 bug Something isn't working label Oct 28, 2024
Copy link
Member

@johannes-wolf johannes-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but I've created a follow up that includes the missing test file.

@johannes-wolf
Copy link
Member

Closing in favor of #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👿 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation domain always includes the origin
2 participants