Add comb plot element #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
johannes-wolf
approved these changes
Nov 7, 2024
johannes-wolf
merged commit d9bf4f2
into
cetz-package:refactor-plot-part-one
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #81 (and #83 to some extent)
The test ref has a budding test set, but it would be nice to have more. Takes an array (or dictionary), that must contain (x,y) coordinates and optionally a custom stroke, mark, (and when annotations are fixed, label that is displayed above). The keys can be set for each of these parameters allowing for a diverse range of input data shapes.
Plot legend has been kept as the default to maintain compatibility with other plot legend types (for when series are implemented)
To do: