sample: Add "int" option to sampling domain #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
sample-int
branch
2 times, most recently
from
981b84d to
5492cc3
Compare
johannes-wolf
force-pushed
the
sample-int
branch
from
5492cc3 to
c8c5803
Compare
|
I think in principle this works, but it doesn't "feel" like any of the other cetz or cetz-plot API. Would it be preferable to instead abstract this away into a separate construction (perhaps "sampler") which is passed as an object to |
|
I will add this feature (+ the change to a callback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing
"INT"todomain:ofsample-fnand all plot commands that forward to this function.This make sampling at integer values easier.