Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: Bring back implicit frame #754

Merged
merged 1 commit into from
Nov 28, 2024
Merged

content: Bring back implicit frame #754

merged 1 commit into from
Nov 28, 2024

Conversation

johannes-wolf
Copy link
Member

Fixes #753

@johannes-wolf johannes-wolf added the bug 🐛 Something isn't working label Nov 22, 2024
@johannes-wolf johannes-wolf added this to the 0.3.2 milestone Nov 24, 2024
@johannes-wolf johannes-wolf mentioned this pull request Nov 27, 2024
Closed
jamesrswift
jamesrswift approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jamesrswift jamesrswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Remember running into this recently when trying my hand at molecular structures

@johannes-wolf johannes-wolf merged commit 8ec6384 into master Nov 28, 2024
1 check passed
@johannes-wolf johannes-wolf deleted the content-implicit-frame branch November 28, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrswift jamesrswift jamesrswift approved these changes

@fenjalien fenjalien Awaiting requested review from fenjalien

Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.

Lines between contents do not work properly in 0.3
2 participants
@johannes-wolf @jamesrswift