Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-9167: Added ci scripts and github workflow to use them #1233

Closed
wants to merge 2 commits into from

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Jun 28, 2023

With the idea that this can be re-used by other projects as well as locally for developers.

Ticket: ENT-9617
Changelog: none

merge with https://github.com/cfengine/mission-portal/pull/1996

@craigcomstock craigcomstock changed the title ENT-9617: Added shareable github workflow to build hub package ENT-9617: Added ci scripts and github workflow to use them Jun 28, 2023
@craigcomstock
Copy link
Contributor Author

@Lex-2008 it seems that I can't share a secret from another repo's workflow calling this one when this one is a fork maybe? https://github.com/craigcomstock/mission-portal/actions/runs/5405047467/jobs/9821221095

@craigcomstock craigcomstock marked this pull request as draft June 29, 2023 13:01
@craigcomstock craigcomstock removed the request for review from Lex-2008 June 29, 2023 13:01
@craigcomstock craigcomstock changed the title ENT-9617: Added ci scripts and github workflow to use them ENT-9167: Added ci scripts and github workflow to use them Jul 17, 2023
@craigcomstock craigcomstock marked this pull request as ready for review July 18, 2023 15:48
@craigcomstock craigcomstock force-pushed the ENT-9617/master branch 2 times, most recently from 50c67ae to 99ce912 Compare July 18, 2023 15:50
Lex-2008
Lex-2008 previously approved these changes Jul 18, 2023
Copy link
Contributor

@Lex-2008 Lex-2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff!

ci/build.sh Show resolved Hide resolved
ci/setup.sh Outdated Show resolved Hide resolved
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Jul 19, 2023

Success! mission-portal PR works with these changes: https://github.com/cfengine/mission-portal/actions/runs/5589562312/jobs/10250286606 🟢

From logs

HEAD is now at 6ceab45 Merge 7be74b30c2f102995c0c4666477ab593110c5b94 into eaa595690812ea3323c9a8529783fb7e696e2961

7be74b3 matches! So github worked! :O

Includes unused build-scripts/clean-dependencies which I found helpful while iterating locally.

Ticket: ENT-9167
Changelog: none
Ticket: ENT-9167
Changelog: none
@craigcomstock
Copy link
Contributor Author

let's prefer the in-repo PR: #1239 since that will tell us if the workflow works in buildscripts by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants