-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-9170: Added deplyment tests for built enterprise hub package #1248
Conversation
Thanks for submitting a pull request! Maybe @Lex-2008 can review this? |
@cf-bottom jenkins please, to check if my changes to |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9661/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9661/ |
98d12f8
to
89ef684
Compare
0fdcff0
to
35cc36c
Compare
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9680/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9680/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider my review very good, but I very much appreciate all the comments in the scripts.
Also check the hash to ensure it is unique or fail the script. Ticket: ENT-10419 Changelog: none
Can be run in docker or on a plain host (vm/metal) Also added step in docker build to get sftp cached deps packages Requires either GH env var ssh private key or mystiko (password-store repo) Ticket: ENT-9170 Changelog: none
094ffb4
to
4db36c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I fully grok it, but it looks good.
Can be run in docker or on a plain host (vm/metal)
Ticket: ENT-9170
Changelog: none
need changes from https://github.com/cfengine/nova/pull/2091