Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-9170: Added deplyment tests for built enterprise hub package #1248

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Aug 8, 2023

Can be run in docker or on a plain host (vm/metal)

Ticket: ENT-9170
Changelog: none

need changes from https://github.com/cfengine/nova/pull/2091

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @Lex-2008 can review this?

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please, to check if my changes to autogen are "ok". :)

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins please

@cf-bottom
Copy link

nickanderson
nickanderson previously approved these changes Aug 22, 2023
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider my review very good, but I very much appreciate all the comments in the scripts.

ci/docker-build-package.sh Show resolved Hide resolved
Also check the hash to ensure it is unique or fail the script.

Ticket: ENT-10419
Changelog: none
Can be run in docker or on a plain host (vm/metal)

Also added step in docker build to get sftp cached deps packages

Requires either GH env var ssh private key or mystiko (password-store repo)

Ticket: ENT-9170
Changelog: none
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I fully grok it, but it looks good.

build-scripts/autogen Show resolved Hide resolved
ci/docker-build-package.sh Show resolved Hide resolved
@craigcomstock craigcomstock merged commit e4b2783 into master Aug 23, 2023
2 checks passed
@craigcomstock craigcomstock deleted the ENT-9170/master branch August 23, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants