Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-9517: Modified zlib URL to adjust for new release (3.18) #1278

Merged
merged 2 commits into from
Aug 26, 2023
Merged

ENT-9517: Modified zlib URL to adjust for new release (3.18) #1278

merged 2 commits into from
Aug 26, 2023

Conversation

craigcomstock
Copy link
Contributor

  • Modified zlib URL to adjust for new release
  • Refactored sftp cache ssh key usage into the docker container for full pull/push usage

@craigcomstock
Modified zlib URL to adjust for new release
42185ea 
Keeping the old release requires using the https://zlib.net/fossils/ base URL

Ticket: ENT-9517
Changelog: none
(cherry picked from commit 1b5fad7)
@craigcomstock
Refactored sftp cache ssh key usage into the docker container for ful…
1f83c22 
…l pull/push usage

Before I was pulling the sftp cache on the host outside the container because
I couldn't figure out how to push the sftp cache private key inside the container.

When I changed a dependency, zlib in this case, the build scripts wanted to push
the new packages up to the sftp cache which failed due to lack of private key in the container.

This commit takes either a github secret or mystiko password and sets it as an environment variable inside the container for the build to use.

Ticket: ENT-10419
Changelog: none
(cherry picked from commit b989b9d)
@craigcomstock craigcomstock mentioned this pull request Aug 25, 2023
Merged
@craigcomstock craigcomstock merged commit c64de1d into 3.18.x Aug 26, 2023
3 of 4 checks passed
@craigcomstock craigcomstock deleted the ENT-9157/3.18 branch August 26, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigcomstock @nickanderson