Added cf-secret ComponentRef - 3.21.x #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lex-2008
changed the title
olehermanse
previously approved these changes
Sep 18, 2023
olehermanse
reviewed
Sep 18, 2023
| @@ -183,6 +183,7 @@ | |||
| <ComponentRef Id='cf_promises.exe' /> | |||
| <ComponentRef Id='cf_runagent.exe' /> | |||
| <ComponentRef Id='cf_serverd.exe' /> | |||
| <ComponentRef Id='cf_secret.exe' /> | |||
There was a problem hiding this comment.
Looks like this list is almost alphabetic, should cf_secret be before cf_serverd?
There was a problem hiding this comment.
done! Force-pushed
otherwise, cf-secret.exe was packaged into *.msi, but not installed on a target machine Ticket: ENT-10405 (cherry picked from commit 1042d0b)
Lex-2008
force-pushed
the
ENT-10405-cf-secret.msi-3.21.x
branch
from
27de76c
to
7b5e4e0
Compare
nickanderson
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise, cf-secret.exe was packaged into *.msi, but not installed on a target machine
Ticket: ENT-10405
(cherry picked from commit 1042d0b)
Merge together: cfengine/core#5325