ENT-10647: Added safety for hub upgrade in packaging scriptlets #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
requested review from
Lex-2008,
larsewi,
nickanderson,
vpodzime and
olehermanse
nickanderson
previously approved these changes
Sep 25, 2023
vpodzime
previously approved these changes
Sep 26, 2023
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9886/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9886/ |
craigcomstock
dismissed stale reviews from vpodzime and nickanderson
via
072a042
craigcomstock
force-pushed
the
ENT-10647/master
branch
2 times, most recently
from
a71bba7
to
48c9be6
Compare
|
Needed more refactoring, cancelled the last jenkins build. Will test manually locally and then re-start a jenkins build. |
|
@cf-bottom jenkins |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9888/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9888/ |
|
jenkins run looks good, sequential-tests was ssh flake/failures. |
nickanderson
approved these changes
Sep 26, 2023
vpodzime
approved these changes
Sep 27, 2023
craigcomstock
force-pushed
the
ENT-10647/master
branch
from
48c9be6
to
5ca2eff
Compare
…nstall The pg_ctl stop/start commands don't ensure that the server state is as reqeusted at the moment that the command returns. Added up to 5 seconds of wait time to ensure the state is as we want. Also added some tails of expected logs when failures occur. Either /var/log/postgresql.log or the specific pg_upgrade logs which may be created and mentioned in the output of that command failing. Ticket: ENT-10647 Changelog: title
craigcomstock
force-pushed
the
ENT-10647/master
branch
from
5ca2eff
to
a7e6fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg_ctl stop/start commands don't ensure that the server state is as reqeusted
at the moment that the command returns. Added up to 5 seconds of wait time to
ensure the state is as we want.
Also added some tails of expected logs when failures occur. Either /var/log/postgresql.log
or the specific pg_upgrade logs which may be created and mentioned in the output of that command
failing.
Ticket: ENT-10647
Changelog: title