ENT-10429: Guarded against race condition in install scriptlets with restorecon (3.18) #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to run restorecon with the least number of processes/services running that might make changes to /var/cfengine and /opt/cfengine restorecon seems to gather a list of files up-front and then process which can take more than a few seconds. When services such as database or cf-execd/cf-agent/etc are running files can change causing restorecon to error out when files are removed. The files being removed doesn't create a risk of bad SELinux labels since they are gone. Ticket: ENT-10429 Changelog: title (cherry picked from commit ee76818)
|
@cf-bottom jenkins |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9916/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9916/ |
|
fr-tests expected failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to run restorecon with the least number of processes/services running that might
make changes to /var/cfengine and /opt/cfengine
restorecon seems to gather a list of files up-front and then process which can take more
than a few seconds.
When services such as database or cf-execd/cf-agent/etc are running files can change
causing restorecon to error out when files are removed.
The files being removed doesn't create a risk of bad SELinux labels since they are gone.
Ticket: ENT-10429
Changelog: title
(cherry picked from commit ee76818)