ENT-10739: Improved locale env vars safety during installation for postgresql (3.21) #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found that an LC_CTYPE=UTF-8 from iTerm2 on OSX was breaking the hub package install. PostgreSQL docs suggest using 'C' locale unless otherwise needed https://www.postgresql.org/docs/current/locale.html > The drawback of using locales other than C or POSIX in PostgreSQL is its performance impact. It slows character handling and prevents ordinary indexes from being used by LIKE. For this reason use locales only if you actually need them. Ticket: ENT-10739 Changelog: title (cherry picked from commit 2db105c)
|
@cf-bottom jenkins |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9957/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9957/ |
|
sequential-tests failure is acceptable, related to https://northerntech.atlassian.net/browse/ENT-10710 which is now merged to 3.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that an LC_CTYPE=UTF-8 from iTerm2 on OSX was breaking the hub package install.
PostgreSQL docs suggest using 'C' locale unless otherwise needed
https://www.postgresql.org/docs/current/locale.html
Ticket: ENT-10739
Changelog: title
(cherry picked from commit 2db105c)