Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-10801: Moved sftp cache Wix Tools install from jenkins-vms to package-msi script #1325

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

craigcomstock
Copy link
Contributor

Might as well move the knowledge as close to where it is needed to avoid trouble.

Ticket: ENT-10801
Changelog: none

…ript

Might as well move the knowledge as close to where it is needed to avoid trouble.

Ticket: ENT-10801
Changelog: none
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Installation of tools required for the build has traditionally been done in the build machine setup.

@craigcomstock
Copy link
Contributor Author

I'm not sure about this. Installation of tools required for the build has traditionally been done in the build machine setup.

Sure. But I would prefer that the knowledge of how to setup a build machine is close to where a build machine is used: here.

Ideally I'd like to see all the distribution package dependencies moved here as well.

e.g. https://github.com/cfengine/buildscripts/blob/master/ci/setup.sh and https://github.com/cfengine/buildscripts/blob/master/ci/setup-projects.sh made more generic so they work on all supported platforms.

Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack this should be a temporary fix until we move mingw builds into containers which should then have all the necessary bits in the container image(s).

@craigcomstock craigcomstock merged commit 5642cde into master Oct 24, 2023
3 checks passed
@craigcomstock craigcomstock deleted the ENT-10801/master branch October 24, 2023 14:47
@craigcomstock
Copy link
Contributor Author

cherry picks
#1331
#1330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants