Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.24.x deps 2024 09 06 13 39 17 290986 #1494

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Sep 6, 2024

No description provided.

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins no test

@cf-bottom
Copy link

@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from 91c528d to 231fd44 Compare September 6, 2024 22:00
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins no tests

@cf-bottom
Copy link

@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from 1bfbc78 to 5d1ad9a Compare September 10, 2024 15:27
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins, think I'm ready for the tests

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

Oops. Forgot a fix somewhere from cf-bottom not quite working.

10:33:40 error: File /home/jenkins/workspace/testing-pr/label/PACKAGES_x86_64_linux_redhat_7/openssl/SOURCES/openssl-3.3.1.tar.gz: No such file or directory

will fix.

@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from 5d1ad9a to fb33e3b Compare September 10, 2024 19:38
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from fb33e3b to 119ee9d Compare September 11, 2024 12:56
@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

@vpodzime as you can see looking back in comments here we have a green jenkins build above with these changes.

I just squashed the two fixup commits for openssl into one commit with the upgrade.

Ready for review.

@larsewi
Copy link
Contributor

larsewi commented Sep 12, 2024

Maybe you can update the comment above

Updated postgresql from 16.3 to 15.8

I got a bit confused at first ;)

Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Please check things work not just build on exotics (unless you already did).

build-scripts/install-dependencies Show resolved Hide resolved
@craigcomstock
Copy link
Contributor Author

Maybe you can update the comment above

Updated postgresql from 16.3 to 15.8

I got a bit confused at first ;)

Funny, that's the initial comment that github makes from the initial PR. That wrong version was generated by cf-bottom and then I fixed it. The commit comment is correct and now I have fixed the PR comment. 👍 Good catch.

@craigcomstock
Copy link
Contributor Author

Looks good to me otherwise. Please check things work not just build on exotics (unless you already did).

Right. I will build and test on exotics.

Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcomstock please update the tables in the README (Version numbers in master column and add 3.24.x column).

@olehermanse
Copy link
Member

@craigcomstock why does PR title say 3.24.x but target branch is master?

@craigcomstock
Copy link
Contributor Author

@craigcomstock please update the tables in the README (Version numbers in master column and add 3.24.x column).

Good catch. I used cf-bottom to start the PR but it did a bad job due to a few deps not working well for various reasons.

I will add a todo to the ticket to check this in all three branches: 3.21.x, 3.24.x and master.

@craigcomstock
Copy link
Contributor Author

@craigcomstock why does PR title say 3.24.x but target branch is master?

No idea. I am not actively working on this PR right now, but rather the master one here: #1493

So I will fix things up in due course.

@craigcomstock craigcomstock marked this pull request as draft September 16, 2024 12:58
@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from 257d668 to d4a1cb1 Compare September 18, 2024 14:45
@craigcomstock
Copy link
Contributor Author

reworked the commits from the master deps PR #1493

@craigcomstock
Copy link
Contributor Author

Added cherry pick of 3.21.x removal of dependency table to this PR since that will go inline with this change as well.

@cf-bottom jenkins with exotics

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

retry hpux no-test job: Build Status

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Sep 19, 2024

bootstrap-tests, restart failure is a flake on exotics where cf-serverd is not running, ENT-9767

sequential-tests two failures, look like flakes or existing issues unrelated to dependency upgrades

@craigcomstock craigcomstock marked this pull request as ready for review September 19, 2024 16:33
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last commit should be part of the OpenSSL version bump. Also please remove the cherry picked references to private branches/commits.

@@ -1 +1 @@
https://www.openssl.org/source/
https://github.com/openssl/openssl/releases/download/openssl-3.3.2/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of the source is worth a comment in the commit message. Also, the commit message has a cherry-picked from reference to your private branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW https://openssl-library.org/source/ links every release to github.com, there are no releases and openssl.org/source/ anymore.

$PATCH -p1 < $BASEDIR/buildscripts/build-scripts/perl-488307ffa6.patch
gzip -dc perl-${PERL_VERSION}.tar.gz | tar xf -
cd perl-${PERL_VERSION}
# $PATCH -p1 < $BASEDIR/buildscripts/build-scripts/perl-488307ffa6.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to drop this patching and the patch itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably so. 👍

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Sep 30, 2024

I think the last commit should be part of the OpenSSL version bump. Also please remove the cherry picked references to private branches/commits.

There are 4 commits related to OpenSSL version bump. Do you think all of them should be in one?

fixup perl on centos-7, needs newer List::Utils module so build from source.

fixup openssl windows patch, 0007 for openssl 3.3.2

Upgrade Perl version to latest for platforms like centos-7 that have insufficient version available

Fixed openssl patch 0010 for openssl 3.3.2

Adjusted postgresql release-monitoring ID to reflect current supported version 16.x

301832 was 15.x and we already upgraded to 16.3 recently on master.
https://release-monitoring.org/project/5601/ (PostgreSQL~current) was returning an RC version: 17 currently.
We didn't want that.
But now 17.0 is release so we will take it.

369409 pointed to 17 when it was an RC so also not helpful.
Ticket: ENT-12140
Changelog: none
Added note to refer to master README.md and individual files instead of README.md in LTS branches.

Ticket: ENT-12140
Changelog: none
@craigcomstock craigcomstock force-pushed the 3.24.x-deps-2024-09-06_13_39_17_290986 branch from d4a1cb1 to 9fc47e6 Compare September 30, 2024 21:23
@craigcomstock
Copy link
Contributor Author

This PR is proposed to merge to master. This is incorrect for this 3.24.x deps update. Will resubmit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants