Skip to content

Removed node_modules after build #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed node_modules after build #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build-scripts/bootstrap-tarballs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ log_debug "Installing javascript npm dependencies..."
run_and_print_on_failure npm ci --prefix "$BASEDIR"/mission-portal/public/scripts/
# build react components
run_and_print_on_failure npm run build --prefix "$BASEDIR"/mission-portal/public/scripts/
# remove the packages specified in devDependencies
run_and_print_on_failure npm prune --omit=dev --prefix "$BASEDIR"/mission-portal/public/scripts/
# remove node_modules since the bundles are already built
run_and_print_on_failure rm -rf "$BASEDIR"/mission-portal/public/scripts/node_modules
fi
)

Expand Down
5 changes: 3 additions & 2 deletions ci/setup-projects.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ if test -f "mission-portal/public/scripts/package.json"; then
npm ci
# build react components
npm run build
# remove the packages specified in devDependencies
npm prune --omit=dev
# remove node_modules since the bundles are already built
# we do not need them to be presented in the package
rm -rf node_modules
fi
)

Expand Down
3 changes: 0 additions & 3 deletions packaging/common/cfengine-hub/postinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,10 +997,7 @@ chmod 0700 -R $PREFIX/httpd/htdocs/ldap/config

# changed permissions and owner of PHP and JS dependencies
chown root:$MP_APACHE_USER -R $PREFIX/httpd/htdocs/vendor
chown root:$MP_APACHE_USER -R $PREFIX/httpd/htdocs/public/scripts/node_modules

chmod -R ug=rX,o= $PREFIX/httpd/htdocs/vendor # 440 for files, 550 for dirs
chmod -R ug=rX,o= $PREFIX/httpd/htdocs/public/scripts/node_modules

##
# Start Apache server (and php-fpm if present)
Expand Down