Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-4527: Change delete step and init --masterfiles behavior #159

Merged
merged 3 commits into from
Sep 21, 2023
Merged

CFE-4527: Change delete step and init --masterfiles behavior #159

merged 3 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. Changed delete step behavior to allow for non-existent paths 

    Before this would cause an assert, stacktrace and abort of the program.

Now it causes a warning:

WARNING: delete: path 'out/steps/001_masterfiles_793214c10cd0d1f31e8ca44ab05790554776772a/templates/README.md' does not exist, skipping

Ticket: CFE-4257
Changelog: title
    @craigcomstock
    craigcomstock committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3841df8 View commit details
    Browse the repository at this point in the history

  2. Changed init --masterfiles implementation to add with commit instead … 

    …of modify index version of masterfiles module

Previously, if the alternate masterfiles branch/commit had different steps they would not be included in cfbs.json

Ticket: CFE-4257
Changelog: title
    @craigcomstock
    craigcomstock committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b451f92 View commit details
    Browse the repository at this point in the history

  3. Update cfbs/utils.py 

    Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
    @craigcomstock @olehermanse
    craigcomstock and olehermanse authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8b910a2 View commit details
    Browse the repository at this point in the history