Fixed pretty formatting of first cfbs init commit #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olehermanse
commented
Jan 11, 2024
olehermanse
commented
- De-duplicated cfbs sorting rules
- Renamed sorting rule variables
- Fixed pretty formatting of first cfbs init commit
- Updated imports for top level keys and module keys
Introduced here: cfengine#181 Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
One can be local with underscore prefix, the other can use all caps like the other globals. Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
craigcomstock
approved these changes
Jan 11, 2024
oleorhagen
reviewed
Jan 12, 2024
| @@ -207,7 +209,10 @@ def init_command(index=None, masterfiles=None, non_interactive=False) -> int: | |||
|
|
|||
| config["git"] = do_git | |||
|
|
|||
| write_json(cfbs_filename(), config) | |||
| data = pretty(config, CFBS_DEFAULT_SORTING_RULES) + "\n" | |||
There was a problem hiding this comment.
Q: Why not write it through the cfbs_json object like we do most other things?
There was a problem hiding this comment.
@oleorhagen We can and probably should. It looked like a bit more refactoring than I wanted to do in this commit. (I think CFBSConfig class has some quirks which make it a bit weird to work with before there is a .json file, with the expected fields, at the expected path).
There was a problem hiding this comment.
Feel free to take a stab at it, shouldn't be very hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.