ENT-10229: Improved the warning text when an added local module contains a policy file with an autorun tag #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y file with an autorun tag Ticket: ENT-10229 Signed-off-by: jakub-nt <[email protected]>
|
Thank you for submitting a PR! Maybe @larsewi can review this? |
olehermanse
approved these changes
Aug 2, 2024
| is_autorun_enabled = any( | ||
| m in modules_available for m in ["autorun", "./def.json"] | ||
| ) # only a heuristic | ||
|
|
||
| for file in policy_files: | ||
| if _has_autorun_tag(file): |
There was a problem hiding this comment.
Could and here instead of nested ifs.
There was a problem hiding this comment.
This was on purpose, as the comment at https://github.com/cfengine/cfbs/pull/200/files#diff-16156b18d8d412a896d384b37f3947253ba5f775b6357a7205e0ef533d776d53R301 applies to the first condition, but not the second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.