Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-4179: Added example for usemodule #5241

Closed
wants to merge 4 commits into from

Conversation

nickanderson
Copy link
Member

This example contains example_output making it do double work as an acceptance test.
Since the test framework passing in workdir, the module is initalized from the
policy itself instead of using a begin_src prep section like most other examples
that do double duty as acceptance tests.

Ticket: CFE-4179
Changelog: None

@nickanderson nickanderson requested a review from larsewi May 16, 2023 16:35
@nickanderson
Copy link
Member Author

@cf-bottom jenkins please

@cf-bottom
Copy link

@nickanderson
Copy link
Member Author

@cf-bottom jenkins please

@cf-bottom
Copy link

larsewi
larsewi previously approved these changes May 30, 2023
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example, thanks! Make sure it passes and squash commits ✅

Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's failing in CI.

This example contains example_output making it do double work as an acceptance test.
Since the test framework passing in workdir, the module is initalized from the
policy itself instead of using a begin_src prep section like most other examples
that do double duty as acceptance tests.

Ticket: CFE-4179
Changelog: None
@nickanderson
Copy link
Member Author

It would be a nice example, but I have no idea how to make it pass the tests. check-outputs.pl does that check, and if run without -c it updates the example_output section with the current output. Even locally, If I adjust the test to produce different otuput and run the script without -c it updates the block, but when running through testall it fails showing the new output is identical to the old.

@nickanderson
Copy link
Member Author

Uncle, I give up. I don't get why it fails. comments in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants