-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-4179: Added example for usemodule #5241
Conversation
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9475/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9475/ |
@cf-bottom jenkins please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9476/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9476/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example, thanks! Make sure it passes and squash commits ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's failing in CI.
This example contains example_output making it do double work as an acceptance test. Since the test framework passing in workdir, the module is initalized from the policy itself instead of using a begin_src prep section like most other examples that do double duty as acceptance tests. Ticket: CFE-4179 Changelog: None
b375a28
to
00468c8
Compare
It would be a nice example, but I have no idea how to make it pass the tests. check-outputs.pl does that check, and if run without -c it updates the example_output section with the current output. Even locally, If I adjust the test to produce different otuput and run the script without -c it updates the block, but when running through testall it fails showing the new output is identical to the old. |
Uncle, I give up. I don't get why it fails. comments in the ticket. |
This example contains example_output making it do double work as an acceptance test.
Since the test framework passing in workdir, the module is initalized from the
policy itself instead of using a begin_src prep section like most other examples
that do double duty as acceptance tests.
Ticket: CFE-4179
Changelog: None