Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for libntech without GPL code #5282

Merged
merged 7 commits into from
Aug 4, 2023

Commits on Jul 14, 2023

  1. Define WITH_PCRE for libntech

    Because libntech uses our config.h.
    vpodzime committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    458b774 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Add a new small compatibility library

    With GPL-licensed code taken from libntech/libcompat.
    
    This also means that we have to leave all the function-replacing
    macros to libntech/configure, but that's the correct thing to do
    because libcompat is part of libntech and so libntech/configure
    actually determines which fuctions/code will be part of
    libcompat. The only exception are the *printf() functions because
    their replacements are handled by special macros (see
    m4/snprintf.m4 for gore details) and we need those bits to happen
    in this repo too.
    vpodzime committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a238bec View commit details
    Browse the repository at this point in the history
  2. Create an AM conditional for having system getopt.h

    So that we can make decisions based on it in our Makefile.am
    files.
    vpodzime committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    70fa4f1 View commit details
    Browse the repository at this point in the history
  3. Use xasprintf() instead of asprintf() in cf-testd.c

    We have a wrapper function that checks that memory allocation was
    successful. Plus our function is available in our header file and
    in our utility library for the linker so we don't have to bother
    (in this code) where it comes from.
    vpodzime committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    b87326c View commit details
    Browse the repository at this point in the history
  4. Avoid using xasprintf() with a non-literal format string

    It could be used to print data from the process' memory. Not
    really important in cf-testd, but we should stick to good and
    safe coding practices anyway.
    vpodzime committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bb683d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Avoid using our getopt.h on systems that have their own

    Our version may not be 100 % compatible or at least not 100 %
    optimal for the given system.
    vpodzime committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cc2f364 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76f1f02 View commit details
    Browse the repository at this point in the history