CFE-4254: Allow inheriting attributes using global variables in bodies having local parameters #5324
Conversation
|
|
||
| for (int iteration = 0; iteration < 10; iteration++) | ||
| { | ||
| bool replacement_made = false; | ||
| int var_start = -1; | ||
| char closing_brace = 0; | ||
| for (int c = 0; c < buffer_from[c]; c++) |
There was a problem hiding this comment.
If I'm not missing something this does not make sense and risks stopping too early (if the input is long and its size reaches values near 0-9/a-z ascii values).
There was a problem hiding this comment.
Yeah, WTH was it meant to do...?
amousset
changed the title
amousset
force-pushed
the
inheritance-memory
branch
2 times, most recently
from
e3a223e
to
ec6708e
Compare
|
@cf-bottom may I have a build in Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9858/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9858/ |
|
Thanks for your contribution @amousset 🚀 Could you please add the following meta data to the end of the commit message using the This would help us keep track of changes when updating change logs in upcoming releases. Additionally you can add a |
amousset
force-pushed
the
inheritance-memory
branch
from
ec6708e
to
48d1896
Compare
in bodies having local parameters. This also prevents a memory corruption when an attribute contains external vars but no local vars. Ticket: CFE-4254 Changelog: Bodies can now inherit attributes containing global variables Signed-off-by: Alexis Mousset <[email protected]>
amousset
force-pushed
the
inheritance-memory
branch
from
48d1896
to
a99a1cc
Compare
|
Thanks 🚀 Let's hope for green CI 🤞 |
larsewi
added
the
cherry-pick?
|
Aborted due to network issues. Rebuilding |
|
|
||
| for (int iteration = 0; iteration < 10; iteration++) | ||
| { | ||
| bool replacement_made = false; | ||
| int var_start = -1; | ||
| char closing_brace = 0; | ||
| for (int c = 0; c < buffer_from[c]; c++) |
There was a problem hiding this comment.
Yeah, WTH was it meant to do...?
larsewi
removed
the
cherry-pick?
This also prevents a memory corruption when an inherited attribute contains external vars but no local vars.
https://northerntech.atlassian.net/browse/CFE-4254