-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-12142: Updated docs diagrams #3336
Conversation
@cf-bottom please build this in Jenkins :) |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/608/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-608/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it shows commuting policy files and defining state directly on the hub, generally I would show that as a separate repository that the hub itself interfaces with but that might not be important in this specific image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that's not the point of this diagram, it's to relate the 3 steps (define desired state, ensure / enforce state, verify actual state) with the other diagram. The user could be editing "directly" i.e. using ssh / cf-remote, or it could be going via another git server.
The arrow doesn't really mean "directly". In general, there's always more complexity, and we have to choose what to show (there's the whole TCP / IP stack, routers and switches, TLS connections, firewalls, voltages and electrons, and photons and electromagnetic radiation in the case of WiFi and fiberoptics).
I think it's good as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show the cosmic rays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good improvements.
I already backported this |
Updated the diagrams
Ticket: ENT-12142