Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10841: Updated Settings and Users APIs documentations #3340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ENT-10841: Updated Settings and Users APIs documentations #3340

wants to merge 2 commits into from

Conversation

aleksandrychev
Copy link
Contributor

Ticket: ENT-10841

@aleksandrychev aleksandrychev changed the title ENT-10841: Updated Settings API documentation ENT-10841: Updated Settings and Users APIs documentations Sep 5, 2024
craigcomstock
craigcomstock reviewed Sep 5, 2024
View reviewed changes
api/enterprise-api-ref/status-settings.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/status-settings.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/status-settings.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/users-rbac.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/status-settings.markdown Outdated Show resolved Hide resolved
@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/609/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-609/output/_site/

@aleksandrychev
Updated Settings API documentation
b37ffa6 
Ticket: ENT-10841
Signed-off-by: Ihor Aleksandrychiev <[email protected]>
@aleksandrychev
Added the Unlock users endpoint
7e31bd7 
Signed-off-by: Ihor Aleksandrychiev <[email protected]>
@aleksandrychev
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/610/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-610/output/_site/

craigcomstock
craigcomstock approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go I'd say!

api/enterprise-api-ref/users-rbac.markdown Show resolved Hide resolved
nickanderson
nickanderson approved these changes Sep 6, 2024
View reviewed changes
api/enterprise-api-ref/users-rbac.markdown
## Unlock user

If a system enforces using two-factor authentication (2FA),
users must configure it after their first login within 48 hours.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's whatever passwordExpirationAfterResetHours is set to which happens to default to 48 hours right?

I think 48 hours reads more easily but I think referring to the setting that contains the actual value is a bit more specific and correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson approved these changes

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksandrychev @cf-bottom @nickanderson @craigcomstock